Employment History Gap Detection Failures

class EmploymentHistoryAnalyzer:
    """Analyze employment history for gaps and issues"""
    
    REQUIRED_HISTORY_MONTHS = 24
    GAP_THRESHOLD_DAYS = 31  # Gaps > 1 month need explanation
    
    SELF_EMPLOYMENT_INDICATORS = [
        "owner", "president", "founder", "member",
        "sole proprietor", "partner", "principal"
    ]
    
    def build_timeline(self, employments: list) -> dict:
        """Build employment timeline and detect gaps"""
        sorted_emp = sorted(employments, key=lambda x: x["start_date"])
        
        gaps = []
        prev_end = None
        
        for emp in sorted_emp:
            if prev_end:
                gap_days = (emp["start_date"] - prev_end).days
                
                if gap_days > self.GAP_THRESHOLD_DAYS:
                    gaps.append({
                        "start": prev_end,
                        "end": emp["start_date"],
                        "days": gap_days,
                        "explanation_required": True
                    })
            
            prev_end = emp.get("end_date") or date.today()
        
        return {
            "timeline": sorted_emp,
            "gaps": gaps,
            "total_history_months": self.calculate_history_months(sorted_emp),
            "meets_requirement": len(gaps) == 0 or all(
                g.get("explained") for g in gaps
            )
        }
    
    def detect_self_employment(self, employment: dict) -> dict:
        """Detect if employment is actually self-employment"""
        title = employment.get("title", "").lower()
        company = employment.get("company", "").lower()
        employee_name = employment.get("employee_name", "").lower()
        
        # Check title indicators
        for indicator in self.SELF_EMPLOYMENT_INDICATORS:
            if indicator in title:
                return {
                    "self_employed": True,
                    "indicator": f"title contains '{indicator}'",
                    "documentation_required": ["schedule_c", "tax_returns_2yr"]
                }
        
        # Check if employee name is in company name
        name_parts = employee_name.split()
        for part in name_parts:
            if len(part) > 2 and part in company:
                return {
                    "self_employed": True,
                    "indicator": "employee name matches company name",
                    "documentation_required": ["schedule_c", "tax_returns_2yr"]
                }
        
        return {"self_employed": False}
    
    def detect_overlaps(self, employments: list) -> list:
        """Detect overlapping employment periods"""
        overlaps = []
        
        for i, emp1 in enumerate(employments):
            for emp2 in employments[i+1:]:
                if self.dates_overlap(emp1, emp2):
                    overlaps.append({
                        "employer1": emp1["company"],
                        "employer2": emp2["company"],
                        "overlap_period": self.get_overlap_period(emp1, emp2),
                        "clarification_needed": True
                    })
        
        return overlaps